-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ruby 3.4 compatibility #322
Conversation
Thanks for opening a new PR! |
No idea what's wrong |
I'm not sure what changed in Ruby 3.4 for this require to no longer be needed, but we'll surely need to still require it for older Ruby versions. For example: require 'pg_query/pg_query' unless RUBY_VERSION > '3.4' Also note that you'll want to add Ruby 3.4 to the CI matrix. But with the comment on that line, there may be some extra work to support Ruby 3.4 in the protobuf gem. |
52b98a2
to
b973a95
Compare
Updated, added 3.4.0-rc1 to matrix (would Found |
Turns out it might be development version specific issue Locally run on 3.2, 3.3, 3.4.0-rc1 No idea how to test freebsd one (not in CI matrix as well) |
Yes I forgot to run bundle update, my fault... |
It looks like it's still failing on 3.4 due to protobuf issues, but it's also failing on 2.7. I think for 2.7, we could consider dropping it, since that's been out of support for over a year... |
Ya |
Do we want to try using |
New version of This PR is updated to point to 3.4 (also removed 2.7 like you said |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the contribution & your patience on getting this merged. FWIW, I did make a few edits to the extconf.rb code to make it shorter and easier to understand.
Same as #320 but that PR got no workflow to approve anymore and author not responding for 5 days